first stab at eip155:0 lang in eip155/caip2.md #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdenhartog
reviewed
Sep 26, 2025
bumblefudge
commented
Oct 8, 2025
|
Has there been any thought about the backwards compatibility with this yet? E.g. I don't think you'll be able to drop and replace this in a EIP-712 signature because conformance there expects the chainId is a JSON integer. This is probably something that will need to be informed by implementer feedback taking in mind that stuff like this led to many wallets having responsible disclosure bugs reported around this: https://www.coinspect.com/blog/chainid-eip-712-implementation-issue/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussions coming out of the CAIP-25 syntax overhaul conversation made me realize this should've been specified a long time ago!